Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #377 - Build: Upgraded to Grunt 0.4.0 #423

Closed
wants to merge 2 commits into from
Closed

Issue #377 - Build: Upgraded to Grunt 0.4.0 #423

wants to merge 2 commits into from

Conversation

JamesMGreene
Copy link
Member

Build: Upgraded to Grunt 0.4.0. Fixes #377.

options: {
jshintrc: 'test/.jshintrc'
},
files: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work fine as files: [...], doesn't need the nested stuff. I might confuse something, but please give it a try. If it works, apply everywhere.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the same thing ~1 week ago when I tried just what you said but it doesn't work... gives a nasty warning message:

Warning: Cannot use 'in' operator to search for 'src' in addons/**/*.js
Use --force to continue.

What you are thinking of can currently only be done as the value of a target without any options, etc. e.g.

tests: ['test/**/*.js']

Talked to @cowboy about it on IRC last week to confirm. At least 1 other Grunt collaborator thought that would be a great enhancement, though I forgot who... maybe @tkellen or @sindresorhus?

@JamesMGreene
Copy link
Member Author

OK, we good now?

@JamesMGreene
Copy link
Member Author

BTW, thanks for chiming in @sindresorhus!

@jzaefferer
Copy link
Member

Yep, this is good. Just squash this into one commit when merging. Thanks.

@JamesMGreene
Copy link
Member Author

Pushed in 2f7cad5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Update to grunt 0.4
4 participants